Syncing Photos from MacBook not working

[LRussoPhoto]

Ive been syncing photos from a folder on my MacBook to my apple devices for years. Recently it hasn't been working correctly it doesn't update all the new phones and there doesn't seem too be a pattern. If i try to resync a few times usually eventually it works. But now with this latest update its not working. This time when i connected to my MacBook it was almost like a new device was detected. It asked to trust this device and had to accept on my iPhone. When i went to sync it asked to replace all the photos on the iPhone with the folder i had chosen, the folder was correct to i choose to replace. Well now all the photo albums are gone. I tried to resync a few times but for some reason its only copying one album and its the same album each time. Oh and as i watch the sync status bar, it says its copying x amount of photos.
Whats going on?